huggingface / dataset-viewer

Backend that powers the dataset viewer on Hugging Face dataset pages through a public API.
https://huggingface.co/docs/dataset-viewer
Apache License 2.0
695 stars 77 forks source link

CI: how to acknowledge a "safety" warning? #18

Closed severo closed 3 years ago

severo commented 3 years ago

We use safety to check vulnerabilities in the dependencies. But in the case below, tensorflow is marked as insecure while the last published version on pipy is still 2.6.0. What to do in this case?

+==============================================================================+
|                                                                              |
|                               /$$$$$$            /$$                         |
|                              /$$__  $$          | $$                         |
|           /$$$$$$$  /$$$$$$ | $$  \__//$$$$$$  /$$$$$$   /$$   /$$           |
|          /$$_____/ |____  $$| $$$$   /$$__  $$|_  $$_/  | $$  | $$           |
|         |  $$$$$$   /$$$$$$$| $$_/  | $$$$$$$$  | $$    | $$  | $$           |
|          \____  $$ /$$__  $$| $$    | $$_____/  | $$ /$$| $$  | $$           |
|          /$$$$$$$/|  $$$$$$$| $$    |  $$$$$$$  |  $$$$/|  $$$$$$$           |
|         |_______/  \_______/|__/     \_______/   \___/   \____  $$           |
|                                                          /$$  | $$           |
|                                                         |  $$$$$$/           |
|  by pyup.io                                              \______/            |
|                                                                              |
+==============================================================================+
| REPORT                                                                       |
| checked 137 packages, using free DB (updated once a month)                   |
+============================+===========+==========================+==========+
| package                    | installed | affected                 | ID       |
+============================+===========+==========================+==========+
| tensorflow                 | 2.6.0     | ==2.6.0                  | 41161    |
+==============================================================================+
severo commented 3 years ago

See https://github.com/huggingface/datasets-preview-backend/runs/3481625964

severo commented 3 years ago

The vulnerability (I don't think i affects us):

{
            "advisory": "TensorFlow 2.6.0 includes a fix for CVE-2021-37686: In affected versions the strided slice implementation in TFLite has a logic bug which can allow an attacker to trigger an infinite loop. This arises from newly introduced support for ellipsis in axis definition (https://github.com/tensorflow/tensorflow/blob/149562d49faa709ea80df1d99fc41d005b81082a/tensorflow/lite/kernels/strided_slice.cc#L103-L122). An attacker can craft a model such that 'ellipsis_end_idx' is smaller than 'i' (e.g., always negative). In this case, the inner loop does not increase 'i' and the 'continue' statement causes execution to skip over the preincrement at the end of the outer loop. We have patched the issue in GitHub commit dfa22b348b70bb89d6d6ec0ff53973bacb4f4695. TensorFlow 2.6.0 is the only affected version.",
            "cve": "CVE-2021-37686",
            "id": "pyup.io-41161",
            "specs": [
                "==2.6.0"
            ],
            "v": "==2.6.0"
        },
severo commented 3 years ago

Just has to RTFM: https://github.com/pyupio/safety#--ignore--i

severo commented 3 years ago

Closed by https://github.com/huggingface/datasets-preview-backend/commit/2ecc5244e030ce24ecbb4883002264efe5e09fce