The string representation of the storage client is used by the orchestrator DeleteDatasetStorageTask in both the task id attribute and as a label for prometheus_client Histogram:
Since the inclusion of the URL signer to the storage client by PR:
2298
the string representation of the storage client is something like:
StorageClient(protocol=s3, storage_root=hf-datasets-server-statics-test/assets, base_url=https://datasets-server-test.us.dev.moon.huggingface.tech/assets, overwrite=True), url_signer=<libcommon.cloudfront.CloudFront object at 0x55f27a209110>)
See the url_signer: url_signer=<libcommon.cloudfront.CloudFront object at 0x55f27a209110>
This is a different value for each CloudFront instantiation
This PR fixes the string representation of the URLSigner to be its class name, and therefore it fixes as well the string representation of the storage client to be something like:
Fix string representation of storage client.
The string representation of the storage client is used by the orchestrator
DeleteDatasetStorageTask
in both the taskid
attribute and as alabel
for prometheus_client Histogram:Since the inclusion of the URL signer to the storage client by PR:
2298
the string representation of the storage client is something like:
url_signer=<libcommon.cloudfront.CloudFront object at 0x55f27a209110>
CloudFront
instantiationThis PR fixes the string representation of the URLSigner to be its class name, and therefore it fixes as well the string representation of the storage client to be something like:
url_signer=CloudFront