[Ready to merge] Add Bonus Unit 5

huggingface / deep-rl-class

This repo contains the syllabus of the Hugging Face Deep Reinforcement Learning Course.

Apache License 2.0

3.91k stars 603 forks source link

[Ready to merge] Add Bonus Unit 5 #537

Closed Ivan-267 closed 5 months ago

Ivan-267 commented 5 months ago

Adds Bonus Unit 5. Imitation Learning with Godot RL Agents

TODO:

[x] Upload and add link for downloading the zip file with starter/completed project.
[x] Review the content and correct any other issues (a quick check performed with correction of smaller issues)

HuggingFaceDocBuilderDev commented 5 months ago

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

simoninithomas commented 5 months ago

Let me know what you think of the thumbnail @Ivan-267 @edbeeching

Ivan-267 commented 5 months ago

Let me know what you think of the thumbnail @Ivan-267 @edbeeching

Looks great!

simoninithomas commented 5 months ago

Cool 🔥 @Ivan-267 I was thinking we can publish the unit tomorrow or monday/tuesday? What suits you best?

I gave some changes requests but overall, the unit is excellent 👏

Ivan-267 commented 5 months ago

Thanks for your review and making the image, I've sent some additional comments over E-mail.

simoninithomas commented 5 months ago

Hi one last update is to put the link of the zip in the course and we're good to publish 🔥

Ivan-267 commented 5 months ago

Hi one last update is to put the link of the zip in the course and we're good to publish 🔥

Hey, I added the link here: https://github.com/huggingface/deep-rl-class/blob/dc2c8bf8998efa4f1a5210e1df076abd0836c034/units/en/unitbonus5/getting-started.mdx?plain=1#L3

If you'd like I could change the link to direct link, but I wasn't sure how it works with the server so the current way was the safest.

The newer changes in the PR don't show up in the doc preview.

simoninithomas commented 5 months ago

Yes I just saw I just launch the build PR documentation to check. But your link is correct

For the environmelnt repository I added a PR: https://huggingface.co/ivan267/imitation-learning-tutorial-godot-project/discussions/1

We can publish it this afternoon or any other day you prefer @Ivan-267 ?

Ivan-267 commented 5 months ago

Yes I just saw I just launch the build PR documentation to check. But your link is correct

For the environmelnt repository I added a PR: https://huggingface.co/ivan267/imitation-learning-tutorial-godot-project/discussions/1

We can publish it this afternoon or any other day you prefer @Ivan-267 ?

Thanks for adding the readme, I merged it. We can publish it today or whenever is convenient.

simoninithomas commented 5 months ago

Hi what we can do is to publish it this afternoon 🔥 @edbeeching

What would be nice @Ivan-267 is:

A tweet with the video of the robot playing. with the link of the unit. For instance: "I wrote a tutorial on how to train a robot to play platform games using imitation learning Start learning now 👉 " something better but you got the idea 😅
Same with Linkedin.

If you want what we can do:

You write a short tweet on the fact you wrote a unit where people will train this small robot to play plaftorm games using imitation learning. You publish it with your account
I reshare with my account and try to reshare with HF account.
Same for Linkedin.
I write the announcement on discord by tagging rl people and tagging you.

So that your profile get promoted. But again tell me if you comfortable with that or if you have another idea?

simoninithomas commented 5 months ago

I'm merging it thanks 🔥