search

huggingface / deep-rl-class

This repo contains the syllabus of the Hugging Face Deep Reinforcement Learning Course.
Apache License 2.0
3.71k stars 564 forks source link

unit3 error message when pushing model to hugging face #539

Closed foye501 closed 1 week ago

foye501 commented 2 weeks ago

Describe the bug

in unit3 I run into error message when pushing model to hugging face?

Screenshot 2024-06-12 at 16 05 12

A clear and concise description of what the bug is. Please share your notebook link so that we can reproduce the error

Material

If not:

simoninithomas commented 2 weeks ago

Hey there 👋

Did you tried to just run solutions of the notebook to test if it works correctly?

If yes, please provide your notebook link so that I can check what's the problem

foye501 commented 2 weeks ago

Hey there 👋

Did you tried to just run solutions of the notebook to test if it works correctly?

If yes, please provide your notebook link so that I can check what's the problem

Yes, I have just try the solution except that of pushing model. It failed again, I guess maybe the version of some package doesn't right. Thank you for your help.

this is my notebook https://colab.research.google.com/github/huggingface/deep-rl-class/blob/main/notebooks/unit3/unit3.ipynb#scrollTo=co5um_KeKbBJ

simoninithomas commented 2 weeks ago

So I tested it and it work correctly:

  1. Did you changed orga here with your username (beware that if you have MAJ it takes into account, for instance my username is ThomasSimonini not thomassimonini).

!python -m rl_zoo3.push_to_hub --algo dqn --env SpaceInvadersNoFrameskip-v4 --repo-name dqn-SpaceInvadersNoFrameskip-v4vvvv -orga ThomasSimonini -f logs/

  1. When you put your write token above did it says your token was correct?
simoninithomas commented 2 weeks ago
Screenshot 2024-06-13 at 10 30 25
foye501 commented 2 weeks ago

So I tested it and it work correctly:

  1. Did you changed orga here with your username (beware that if you have MAJ it takes into account, for instance my username is ThomasSimonini not thomassimonini).

!python -m rl_zoo3.push_to_hub --algo dqn --env SpaceInvadersNoFrameskip-v4 --repo-name dqn-SpaceInvadersNoFrameskip-v4vvvv -orga ThomasSimonini -f logs/

  1. When you put your write token above did it says your token was correct?

Thank you, I tried it again. I am sure that I loged in using the tokens. but I still face the keyerror, this is my copy of notebook. https://colab.research.google.com/drive/13R97v7Xcyyn-qFao4iyuC1ywgBzvDngE#scrollTo=2RVEdunPHs8B

foye501 commented 2 weeks ago

It creates a empty folder in my huggingface , https://huggingface.co/foye501/SpaceInvadersNoFrameskipv4

simoninithomas commented 1 week ago

I don't have access to your notebook I just asked access.

foye501 commented 1 week ago

I don't have access to your notebook I just asked access.

Thank you

simoninithomas commented 1 week ago

Hi, I tried from scratch it seems to work. Are you sure you didn't missed a step:

For me the best is take the notebook from scratch: a new version of the notebook.

foye501 commented 1 week ago

Thank you, I will try it again, Thank you.

Thank you, I will try it again, Thank you.

Hi, I tried from scratch it seems to work. Are you sure you didn't missed a step:

  • Did you created dqn.yml?
  • Did your read the messages after the training? If it wasn't saved etc?

For me the best is take the notebook from scratch: a new version of the notebook.

Thank you, I will try it again, Thank you.

simoninithomas commented 1 week ago

I'm closing the issue for now, if there's still an issue after your new tries, please open a new one 🤗