huggingface / diffusers

🤗 Diffusers: State-of-the-art diffusion models for image and audio generation in PyTorch and FLAX.
https://huggingface.co/docs/diffusers
Apache License 2.0
25.99k stars 5.35k forks source link

RunwayML obsoletion causes issues #9322

Closed vladmandic closed 6 days ago

vladmandic commented 2 months ago

Describe the bug

RunwayML just removed their entire code from huggingface!
See note at https://huggingface.co/runwayml: "We are no longer maintaining a HuggingFace organization"

Which causes pretty big issues since runwayml/stable-diffusion-v1-5 is referenced as default/fallback in many places in the code. for example, loaders/single_file_utils.py has

DIFFUSERS_DEFAULT_PIPELINE_PATHS = {
    ...
    "inpainting": {"pretrained_model_name_or_path": "runwayml/stable-diffusion-inpainting"},
    "v1": {"pretrained_model_name_or_path": "runwayml/stable-diffusion-v1-5"},
    ...
}

Reproduction

N/A

Logs

N/A

System Info

N/A

Who can help?

@yiyixuxu @sayakpaul @DN6 @asomoza

yiyixuxu commented 2 months ago

thanks @vladmandic we are looking into this now!

yiyixuxu commented 2 months ago

@vladmandic will this work as a temporary resolution? will update once we decide what to do with this

vladmandic commented 2 months ago

@vladmandic will this work as a temporary resolution? will update once we decide how to host them

yes, it should, although its probably better to have it hosted under hf account and not reference a random 3rd party model.

yiyixuxu commented 2 months ago

@vladmandic should I wait to merge then? yes we are looking into that, and if this is not urgent for you I'd rather to wait util that decision is made

yuanhao-li commented 2 months ago

@yiyixuxu can you also fix this example? https://github.com/huggingface/diffusers/tree/main/examples/controlnet

thank you.

vladmandic commented 2 months ago

for most of cases, sdnext already uses offline config files, this issue pops up in some border cases - i'd say its important, but can wait a proper solution for a day.

yiyixuxu commented 2 months ago

@vladmandic @dave-gray101. I merged #https://github.com/huggingface/diffusers/pull/9323 so single file support should be back on now

vladmandic commented 2 months ago

thanks - that'[s now on main - what about doing a service pack release? this is serious enough for that.

yiyixuxu commented 2 months ago

@vladmandic yes!

isidentical commented 2 months ago

I'd really encourage huggingface to either take some decisive action and replace that repo that automatically points to a well maintained fork OR reinstate it completely. this is causing too many transient errors with everything that depends on it.

asomoza commented 2 months ago

This was just a quick fix for the moment, also the model we linked as a patch is the most used one for SD 1.5 and I believe if the author, which is a well known person takes it down, the backslash for doing it will be a lot more than the base one, so I don't think we need to worry about that until we provide a better fix soon.

github-actions[bot] commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

yiyixuxu commented 1 month ago

partially resolved but we still need to update everywhere in our doc with https://huggingface.co/stable-diffusion-v1-5 let me know if anyone is interested!

github-actions[bot] commented 1 week ago

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

sayakpaul commented 6 days ago

I think this was resolved?