huggingface / diffusers

🤗 Diffusers: State-of-the-art diffusion models for image and audio generation in PyTorch and FLAX.

https://huggingface.co/docs/diffusers

Apache License 2.0

26.35k stars 5.43k forks source link

Move IP Adapter Scripts to research project #9960

Closed ParagEkbote closed 6 days ago

ParagEkbote commented 1 week ago

What does this PR do?

I have moved the IP Adapter Scripts to the research project folder as mentioned, to close #7196. Please let me know if any further corrections are needed and I will make the necessary changes.

Similar to #9935 .

Before submitting

[x] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[x] Did you read the contributor guideline?
[x] Did you read our philosophy doc (important for complex PRs)?
[x] Was this discussed/approved via a GitHub issue or the forum? Please add a link to it if that's the case.
[x] Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.

Who can review?

@sayakpaul

sayakpaul commented 1 week ago

Can you cherry-pick the commits from https://github.com/huggingface/diffusers/pull/7196 and then add a commit to move them to research folder? This way, the original contributions receive the proper credits they deserve.

pcuenca commented 1 week ago

Can you cherry-pick the commits from #7196 and then add a commit to move them to research folder?

Agreed, or start the branch from the other PR's branch if that's easier.

ParagEkbote commented 1 week ago

I have copied the contents from #7196 and added them to research project. Should I credit the user in the ReadME, since the branch in that repository is out-of-date.

cc: @sayakpaul

sayakpaul commented 1 week ago

You should still be able to cherry-pick commits.

ParagEkbote commented 6 days ago

I have cherry-picked the commits and moved files to the research project folder. Please let me know if any further corrections are needed and I will make the necessary changes.

cc: @sayakpaul

sayakpaul commented 6 days ago

Can you run make style && make quality?

ParagEkbote commented 6 days ago

I have run the styling checks and resolved the git conflict. Please let me know if any further corrections are needed and I will make the necessary changes.

cc: @pcuenca

HuggingFaceDocBuilderDev commented 6 days ago

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

sayakpaul commented 6 days ago

@ParagEkbote could I ask you to be a bit more respectful of the maintainers’s time for PRs?

You have requested for reviews multiple times now and have also mentioned multiple times. This, IMO, seems unnecessary.

ParagEkbote commented 6 days ago

@sayakpaul Sorry, I'll try to do better.

sayakpaul commented 6 days ago

@stevhliu do the docs-related changes look good to you?

ParagEkbote commented 6 days ago

Could you please see that #7196 gets closed to declutter?

cc: @stevhliu