Feature/orbitalcontrols camera configuration

huggingface / gsplat.js

JavaScript Gaussian Splatting library.

MIT License

1.26k stars 78 forks source link

Closed spark323 closed 7 months ago

spark323 commented 7 months ago

This PR adds the ability for OrbitalControls to set the camera position and direction

dylanebert commented 7 months ago

Thanks :) I made a PR on your fork with some updates (copied):

Naming, formatting for consistency
Removed setPosition, since I believe it has the same function as setting camera.position = directly, which OrbitControls now listens for. Let me know if I'm mistaken and there is a different intended functionality
Update the camera-updates example to test the new method

spark323 commented 7 months ago

I merged your PR and corrected an implementation error. Thanks!

dylanebert commented 7 months ago

Thanks! I just pushed lots of small changes but nothing that conflicts with yours. Feel free to rebase or accept my rebase PR and I'll merge