Fix always None in text_generation output

huggingface / huggingface_hub

The official Python client for the Huggingface Hub.

https://huggingface.co/docs/huggingface_hub

Apache License 2.0

1.82k stars 470 forks source link

Fix always None in text_generation output #2316

Closed Wauplin closed 4 weeks ago

Wauplin commented 4 weeks ago

Fix https://github.com/huggingface/huggingface_hub/issues/2315. Thanks @WesleyTheGeolien for reporting it!

Since recent refacto of the text-generation client (https://github.com/huggingface/huggingface_hub/pull/2237), details=True was not forwarded to TGI, which is a breaking change. This PR fixes it. I'll do a hot-fix release once merged.

HuggingFaceDocBuilderDev commented 4 weeks ago

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Wauplin commented 4 weeks ago

Thanks! failing CI is unrelated so happy to merge :)

WesleyTheGeolien commented 4 weeks ago

Thanks @Wauplin