Closed Wauplin closed 1 day ago
I would love to work on this @Wauplin.
To clarify:
image_segmentation
, image_to_image
, etc.) or just the ones related to chat completions? src/huggingface_hub/inference/_client.py
. Is this correct?Hi @lappemic, thanks for proposing yourself! For now I've created the issue but I'm not sure if we want and how we want to proceed. I've started to test things locally to see how the changes would looks like (API-wise but also internally). I think we will introduce changes only for openai
compatibility but keep the current naming for most/all existing tasks without breaking changes. Changes will happen in both _client.py
and the async client (automatically).
Thanks for the feedback.
Ok, let me know if you decided on how to proceed and if you would like some help!
In the end I opened https://github.com/huggingface/huggingface_hub/pull/2384 with the corresponding changes. Still need to be discussed on new args
_Originally from @philschmid on slack (private):_
Being openai compatible for serving has become a standard so its awesome that TGI is. This also means what we can use openai sdk and it allows us to communicate that you can basically switch from closed source to open source with changing 1 variable (url). A lot of people are familiar with the openai already so the closer you are the easier it is for them to understand and switch. I get that when we have new features we cannot use openai but it might have been cool that we are in parity for everything existing, e.g.
or
Note: to do that we'll need to:
model
tobase_url
model_id
tomodel
token
toapi_key
client.chat.completions.create