search

huggingface / huggingface_hub

The official Python client for the Huggingface Hub.
https://huggingface.co/docs/huggingface_hub
Apache License 2.0
2.14k stars 559 forks source link

Impacts of removing `modelId` #2408

Closed davidmezzetti closed 4 months ago

davidmezzetti commented 4 months ago

Did something change on the HF Hub server side related to this? https://github.com/huggingface/huggingface_hub/pull/2405

It appears that the modelId while deprecated was still returning a value even for the latest version (0.24.0) as of yesterday. But now it's throwing an exception for the same version of the library.

Here are two examples of the impact.

And if we use the last version that supported the modelId attribute v0.18.0, it no longer throws an exception but it just returns None.

Overall, the impact is that this change is breaking code running in production as it's running, which makes it tricky to figure out why all of the sudden it stopped working. While it's an easy fix, it's definitely tough to force users to make an immediate upgrade with no temporary workaround such as reverting or pinning to a prior version.

I'm not sure if this was the intended impact but I just wanted to share this.

julien-c commented 4 months ago

Hi @davidmezzetti thanks for the report. We have reverted the change server-side for now.

We still hope to formally remove this deprecated field in the future.

We'll monitor other reports of breakage, if you see any, let us know!

davidmezzetti commented 4 months ago

Thank you. I appreciate the fix and response!

I made the change to any code I had that was affected. I'll share anything if I see anything.