search

huggingface / huggingface_hub

The official Python client for the Huggingface Hub.
https://huggingface.co/docs/huggingface_hub
Apache License 2.0
2.02k stars 531 forks source link

Fix broken AsyncInferenceClient on [DONE] signal #2458

Closed Wauplin closed 1 month ago

Wauplin commented 1 month ago

Fixed https://github.com/huggingface/huggingface_hub/issues/2455 reported by @cordawyn.

Let's strip bytes messages to avoid newlines. Thanks @cordawyn for noticing and reporting it. I've been able to reproduce it and updated the docs accordingly.

Also a good reminder that cassettes are not ideal for inference tests. Here the bug came from a non-tested TGI update. Surely something to improve in our CI but that will be done in a future CI.

HuggingFaceDocBuilderDev commented 1 month ago

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Wauplin commented 1 month ago

The hot-fix release has been shipped: https://github.com/huggingface/huggingface_hub/releases/tag/v0.24.6.