Closed rish-16 closed 5 years ago
Hey @rish-16
Thank you for the PR! Just made a small update for consistency.
Since you already started, could you also modify the email_parser
in the __main__.py
file (for command-line tools). You can have a look at the slack_parser
for inspiration. And it would great if you could also change the example in the README.
Thanks! Victor
Will do! I'll get started on the CLI version + docs.
Cheers
Alright, I've completed the updates to the CLI version of knockknock
and the README.
Waiting for your feedback.
Cheers, Rish
@rish-16 it looks good to me!
In the CLI, I changed the type to a comma-separated list (it's not recommended to use type=list
with argparse, see here).
I'm merging this and pushing it to pip.
Thank you, @VictorSanh !
Hey there!
I was reading through the issues page and saw a feature request to send emails to multiple recipients. I tweaked the original function into one where the user provides a list of emails instead.
It works something like this:
It was a simple fix: I looped through all the recipient emails and sent it to all of them one by one.
In the case that the
sender_email
isNone
, it will take the first email from therecipient_email_list
list and assign it to thesender_email
.Hope this is useful!