search

huggingface / knockknock

🚪✊Knock Knock: Get notified when your training ends with only two additional lines of code
MIT License
2.78k stars 233 forks source link

add DingTalk chatroom robot notification support #38

Closed wuutiing closed 4 years ago

wuutiing commented 4 years ago

DingTalk is a common used chat app in China, more than 10 million companies and 3 quarters of billion people are using or have used DingTalk. here i've done an implementation for DingTalk support, hope you accept it. a test room is available, search 30005872 in DingTalk. img

VictorSanh commented 4 years ago

I had a look, it looks good to me, I'm merging it as soon as you precized the doc in dingtalk_sender.py (I'm not sure how to modify it so I prefer that you do it). Thanks @wuutiing ! Sorry it took so long.

wuutiing commented 4 years ago

I had a look, it looks good to me, I'm merging it as soon as you precized the doc in dingtalk_sender.py (I'm not sure how to modify it so I prefer that you do it). Thanks @wuutiing ! Sorry it took so long.

Sorry reply late. And have fixed the inference url and readme typo, looking for your comments.