huggingface / knockknock

🚪✊Knock Knock: Get notified when your training ends with only two additional lines of code
MIT License
2.78k stars 233 forks source link

[Slack sender] The channel argument is redundant with the webhook_url argument #51

Open martinp7 opened 4 years ago

martinp7 commented 4 years ago

First of all thanks for the work !

It seems the channel argument is redundant with the webhook_url argument since the creation of a Slack webhook URL requires a channel : the information of the channel is included in the webhook

TODO :

@VictorSanh if you are OK with this, I can do the pull request