Example on Teams is wrong

huggingface / knockknock

🚪✊Knock Knock: Get notified when your training ends with only two additional lines of code

MIT License

2.78k stars 233 forks source link

Example on Teams is wrong #53

Open th0mi opened 4 years ago

th0mi commented 4 years ago

Your example on teams looks like this: @teams_sender(token="<webhook_url_to_your_teams_channel>")

while it should look like that:

@teams_sender(webhook_url="<webhook_url_to_your_teams_channel>")

noklam commented 4 years ago

@th0mi Good catch! I made a typo here. Fixed in the PR

ssameerr commented 3 years ago

I came here to update the same but usually check if someone has already raised to avoid duplication and maintenance for mainteners. is the PR approved?

noklam commented 3 years ago

@VictorSanh