Closed mishig25 closed 2 months ago
cc: @Cadene @aliberts
This looks stunning! Thank you @mishig25
Quick ask before I review: Is there any way we can make the slider wider (like 3-4x wider) for more accurate control?
Quick ask before I review: Is there any way we can make the slider wider (like 3-4x wider) for more accurate control?
https://github.com/huggingface/lerobot/pull/277/commits/69929669060be999d6e0d2f4b82d870db4ac8e2f make slider bigger
For some reason I can't visualize other episodes than the first one. I tried debugging but with no success so far. Do you have the same issue?
https://github.com/huggingface/lerobot/assets/75076266/3cf4f4fb-e075-4313-940a-6f78b3ba0b51
from @Cadene
How to create two columns for the labels? Ideally one for all state*, one for all action*?
commit https://github.com/huggingface/lerobot/pull/277/commits/00dc3e39571db37f1447b7c6218dfd187cee7632
https://github.com/huggingface/lerobot/assets/11827707/dcf3fe04-998f-4344-9d7c-7bb2be43fb15
regarding https://github.com/huggingface/lerobot/pull/277#issuecomment-2173778173
I'm assuming you run: python lerobot/scripts/visualize_dataset_html.py --repo-id lerobot/aloha_mobile_chair --episodes 0 1 2 --port 9090
@aliberts few follow up questions:
python lerobot/scripts/visualize_dataset_html.py ...
, do you also have same problem on https://github.com/huggingface/lerobot/pull/188?--force-override
. If so, does it fix the error ?I'm assuming you run:
python lerobot/scripts/visualize_dataset_html.py --repo-id lerobot/aloha_mobile_chair --episodes 0 1 2 --port 9090
Yes
- When you run
python lerobot/scripts/visualize_dataset_html.py ...
, do you also have same problem on Add visualize_dataset_gtml withhttp.server
#188?
No, I can visualize the other episodes on that branch
- Have you tried running on different dataset?
- Have you tried running with
--force-override
. If so, does it fix the error ?
Okay so that's super weird, now I'm able to make it work with the exact same command I ran yesterday. I must have changed something somehow but I don't know what exactly. I've tried with a number of different dataset and they all worked (lerobot/pusht
, lerobot/aloha_static_tape
, lerobot/aloha_mobile_shrimp
)
What this does
This PR improves dataset_visualizer, both technically & aesthetically. List of improvements:
on branch https://github.com/huggingface/lerobot/pull/188
https://github.com/huggingface/lerobot/assets/11827707/e8848485-1396-4708-b956-e4252cb4a4db
this branch/PR
https://github.com/huggingface/lerobot/assets/11827707/81eebfd0-199e-4d76-8dc6-9035c5b76c61
How to checkout & try? (for the reviewer)
Provide a simple way for the reviewer to try out your changes.
Make sure you install the new dep (
flask
): https://github.com/mishig25/lerobot/blob/ddab25af230d20147e2a126494dc4b3342af91f1/pyproject.toml#L63Checkout this branch:
Run an example visualize_dataset:
s
This change is