Closed DimbyTa closed 2 months ago
Thanks for the PR, I'll give it a spin next week and tell you if it worked well :)
@clefourrier , thank you for reviewing the PR, I appreciate it :)
I already gave the License to The HuggingFace Team, and reverted the naming in tasks/extended/mt_bench/main.py It leaves the issue on using setup.py or to include the entry points in pyproject.toml, I can adapt to your needs.
Thanks again, :)
Agree for maintainability.
However, this raises a question: do we want to convert our already existing script to an actual CLI (to be able to do lighteval list_evals
or `lighteval --accelerate --...)?
(Would expand the scope of the PR)
Agree for maintainability. However, this raises a question: do we want to convert our already existing script to an actual CLI (to be able to do
lighteval list_evals
or `lighteval --accelerate --...)? (Would expand the scope of the PR)
is it possible to do something like, accelerate lighteval ....
?
@muellerzr ? can we use accelerate to launch a lib?
Yes you can, you can do accelerate launch -m mymodule
. Though (and we can discuss this offline) I can show you how to straight up bypass that and call it in your code internally. So it just looks like lighteval dothing
@muellerzr, @clefourrier, @NathanHB . Thank you all for reviewing the PR and commenting on it!
@clefourrier , @NathanHB Could you provide the new requirements? For me to know where we are heading. Thank you! :)
Of course, give us a day to sync on this internally, and we'll come back to you on Wednesday :)
Thank you, I will be waiting. :)
Hi!
We discussed it internally, and it would be great if you could indeed modify the pytoml, to allow lighteval --list-tasks
.
For the rest (launching the rest of the options of lighteval with a CLI), we'll manage it in another PR once yours is merged :)
Hello, I understand. I will revert setup.py to its original state and migrate the console entry point to pytoml.
@clefourrier , @NathanHB Thank you for reviewing the PR, and for the feedback. The task is done now :)
Sorry for all those commits, the ISP here in my country priced up their services and cut down the available Internet data right after I took an engagement to work on Issue #51, so I couldn't install lighteval on my local computer, I didn't have enough internet data volume to cover all the required dependencies. I'm using Google Colab to test all the modifications I make, so I'm pushing before testing rather than testing then pushing :sweat_smile: . It's not ideal but I really want to work on this, so that's the solution I found.
Anyway, I always fail the quality check but when I check what is wrong with the formatting there is no error showing...
The command works fine, just a warning because of the inexistence of the OpenAI API key
No problem for the multiple commits, we squash PRs before merging them, so no trouble really. We'll test it out on our side then merge if it's good.
For style, we usually use the pre-commit hook, you'll find the commands to run there (ruff --fix
and ruff format
)
@clefourrier Thank you, I will check it out.
Hi ! For the quality check you can simply use make style
after installing the correct ruff
version on your python env. (with pip install -e .[dev]
)
Thanks for the advice, @NathanHB.
@clefourrier , @NathanHB , @muellerzr , thank you all for reviewing this PR!
Thank you, for your advice and feedback as well. I appreciate it.
Creation of a CLI command to list tasks #51