search

huggingface / lighteval

Lighteval is your all-in-one toolkit for evaluating LLMs across multiple backends
MIT License
845 stars 100 forks source link

fix(accelerate): Fix missing model_config_path #292

Closed srossi93 closed 2 months ago

srossi93 commented 2 months ago

fix(accelerate): Fix missing model_config_path when creating model config

The argument model_config_path was never passed when creating the model_config.

srossi93 commented 2 months ago

Pinging @hynky1999; The failure of the CI doesn't seem to be related to the content of this PR. Could you please check?

hynky1999 commented 2 months ago

Seems like the secrets are not exposed for user PRs (which make sense from security perspecity) for some reason even tho manually approved. I will check what we can do with it.

Update: No way around this dumb restriction, I will skip the test if the secret is not provided

srossi93 commented 2 months ago

@clefourrier Why was this closed unmerged? #304 fixes a problem with the checks but it doesn’t fix the content of this PR.

clefourrier commented 2 months ago

Hi! This was done automatically by github, let me check why. Edit: the issue you're having was indeed fixed by another PR I merged yesterday evening