search

huggingface / llm-ls

LSP server leveraging LLMs for code completion (and more?)
Apache License 2.0
553 stars 43 forks source link

refactor: adaptor list should be an enum #69

Closed McPatate closed 5 months ago

McPatate commented 5 months ago

https://github.com/huggingface/llm-ls/blob/16606e5371a1b0582543f03fd8a2666f7bf2580a/crates/llm-ls/src/adaptors.rs#L209-L213 could be replaced by an enum

jeremyelalouf commented 5 months ago

Hi @McPatate, if it is still needed (which i think), I would be more than happy to do it :)

McPatate commented 5 months ago

Ah forgot to link the issue with my PR, sorry, I just did it yesterday. Thanks for offering though!

I'll try to keep my list of features to do up to date so that people can contribute if they want :)

jeremyelalouf commented 5 months ago

Okay nice although I'm sad, i really wanted to participate, do you know a good first issue for me @McPatate ?

McPatate commented 5 months ago

Not that I can think of at the moment, sorry!

McPatate commented 5 months ago

Actually there might be a thing, @rojas-diego has offered to add support for multiple encodings in #50.

Not sure if he's still aiming to do it, feel free to take a stab at it :)

The gist: https://gist.github.com/rojas-diego/04d9c4e3fff5f8374f29b9b738d541ef

rojas-diego commented 5 months ago

Hi @McPatate and @jeremyelalouf!

Funny enough Jeremy and I studied at school together in Paris. I'd be happy to get on a call with you Jeremy anytime to collaborate on merging my Gist if you're interested in contributing to the repo!

McPatate commented 5 months ago

Epitech est un petit monde :)

jeremyelalouf commented 5 months ago

Hi @McPatate and @rojas-diego,

Of course, I'm excited about the opportunity to collaborate with you Diego. If there's any way I can assist you, please don't hesitate to reach out 😄