search

huggingface / neuralcoref

✨Fast Coreference Resolution in spaCy with Neural Networks
https://huggingface.co/coref/
MIT License
2.83k stars 474 forks source link

Pin spaCy version to <3 #314

Closed polm closed 3 years ago

polm commented 3 years ago

The latest release of neuralcoref doesn't pin the max spaCy version, so if you pip install neuralcoref it'll happily pull in spaCy 3 and not work. This PR fixes that.

This pin already specified in requirements.txt, but not in setup.py. Also the version spec for requests looks similar, maybe it was put there by mistake?

svlandeg commented 3 years ago

It looks like requests was touched last 2 years ago, so I think that's correct.