huggingface / optimum-intel

🤗 Optimum Intel: Accelerate inference with Intel optimization tools

https://huggingface.co/docs/optimum/main/en/intel/index

Apache License 2.0

364 stars 101 forks source link

Deprecate use_auth_token #684

Closed IlyasMoutawwakil closed 3 months ago

IlyasMoutawwakil commented 3 months ago

What does this PR do?

This PR deprecates use_auth_token in favor of token

Fixes # (issue)

Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you make sure to update the documentation with your changes?
[ ] Did you write any new necessary tests?

HuggingFaceDocBuilderDev commented 3 months ago

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

IlyasMoutawwakil commented 3 months ago

I tried to add warning at the beginning of every function/method that used to accept use_auth_token, then only pass token wich occasionally gets assigned use_auth_token's value. This works with transformers and hugingface_hub functions/methods but not diffusers (some still take use_auth_token only which I commented in loaders)

IlyasMoutawwakil commented 3 months ago

i added a test (that passes) but some cases still fail, like loading+exporting from a private repo, but it's an issue from optimum side.