huggingface / optimum-neuron

Easy, fast and very cheap training and inference on AWS Trainium and Inferentia chips.
Apache License 2.0
176 stars 53 forks source link

fix: bug in get_available_cores within container #546

Closed oOraph closed 3 months ago

oOraph commented 3 months ago

fixes https://github.com/huggingface/optimum-neuron/issues/544

HuggingFaceDocBuilderDev commented 3 months ago

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

oOraph commented 3 months ago

@dacorvo, @JingyaHuang some tests fail but it does not look like it's related to any change made in this pr: it looks like some missing token or auth issue (at least for both tests "Optimum Neuron - Common tests on Trainium" and "Optimum neuron / Test INF1 inference / Run INF1")

can you confirm ?

dacorvo commented 3 months ago

@dacorvo, @JingyaHuang some tests fail but it does not look like it's related to any change made in this pr: it looks like some missing token or auth issue (at least for both tests "Optimum Neuron - Common tests on Trainium" and "Optimum neuron / Test INF1 inference / Run INF1")

can you confirm ?

Yes, builds from forks cannot use the CI token, leading to unauthorized access errors.