search

huggingface / optimum-neuron

Easy, fast and very cheap training and inference on AWS Trainium and Inferentia chips.
Apache License 2.0
176 stars 51 forks source link

Deprecate resume_download #586

Closed Wauplin closed 4 weeks ago

Wauplin commented 2 months ago

Same as https://github.com/huggingface/transformers/pull/30620 and https://github.com/huggingface/diffusers/pull/7843.

With 0.23.0 release, it's best to set the default value of resume_download to None instead of False which will prevent from having a FutureWarning by default.

HuggingFaceDocBuilderDev commented 2 months ago

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

HuggingFaceDocBuilderDev commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

Wauplin commented 1 month ago

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread. Thank you!

I do think this PR is still relevant cc @mfuntowicz

dacorvo commented 1 month ago

Genty pinging @michaelbenayoun and @JingyaHuang . It looks good to me but the changes are not in parts of the code I wrote.