search

huggingface / optimum-nvidia

Apache License 2.0
867 stars 86 forks source link

Fixed Repetition Penalty default value #66

Closed leopra closed 5 months ago

leopra commented 7 months ago

Current default value for repetition penalty is set to 0, this is value is not neutral to the generation output as it is pushing the model to repeat tokens, default value should be 1.0 as in huggingface documentation.

mfuntowicz commented 7 months ago

Thanks @leopra for catching this one!

Everything looks good to me - Awaiting the CI results are ready to merge 👌

leopra commented 6 months ago

@mfuntowicz tests are still failing

mfuntowicz commented 5 months ago

Thanks for your contribution @leopra ! 🤗