huggingface / optimum-quanto

A pytorch quantization backend for optimum

Apache License 2.0

645 stars 36 forks source link

build: fix pyproject.toml #185

Closed baggiponte closed 1 month ago

baggiponte commented 2 months ago

What does this PR do?

Replaces ' with " for consistency in pyproject.toml
Removes setuptools_scm from the [build-backend] section in pyproject.toml
Removes README.md from the dynamic section
Removes setup.py

Fixes #123

Before submitting

[x] Did you read the contributor guideline, Pull Request section?
[x] Was this discussed/approved via a Github issue or the forum? Please add a link to it if that's the case.
[ ] Did you run all tests locally and make sure they pass. They all fail since I am on macOS and PyTorch complains about not being compiled with CUDA 😢
[ ] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

baggiponte commented 2 months ago

Ciao @dacorvo - sorry if I went on and opened this PR but I wanted to try this out locally.

With this setup, I can build quanto locally. I cannot reproduce the metadata bug you mention in the issue I opened. Can you help me create a setup where I can test that? Thanks!

(Also: would you like swapping black for ruff's native formatter? 🔥)

dacorvo commented 2 months ago

With this setup, I can build quanto locally. I cannot reproduce the metadata bug you mention in the issue I opened. Can you help me create a setup where I can test that? Thanks!

I will try it also, but I might request you to add some specific tests to verify that the extension is correctly detected and built on all platforms (typically, before adding setuptools_scm the non-python files were not be included in the package).

(Also: would you like swapping black for ruff's native formatter? 🔥)

https://github.com/huggingface/quanto/issues/186

baggiponte commented 2 months ago

I will try it also, but I might request you to add some specific tests to verify that the extension is correctly detected and built on all platforms

Sure! Would you have some suggestions on how to start and run the tests? e.g. should I use dockerfiles or rely on CI/CD?

(typically, before adding setuptools_scm the non-python files were not be included in the package).

I think this should cover us. Are you referring to the files under quanto/ext?

github-actions[bot] commented 1 month ago

This PR is stale because it has been open 15 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions[bot] commented 1 month ago

This PR was closed because it has been stalled for 5 days with no activity.