search

huggingface / peft

🤗 PEFT: State-of-the-art Parameter-Efficient Fine-Tuning.
https://huggingface.co/docs/peft
Apache License 2.0
16.46k stars 1.62k forks source link

[tests] skip some tests for XPU devices #2074

Closed faaany closed 2 months ago

faaany commented 2 months ago

eetq/hqq/aqlm doesn't support XPU yet. So we want to skip them for now.

HuggingFaceDocBuilderDev commented 2 months ago

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

yao-matrix commented 2 months ago

Thanks for the update to the tests. We'll (hopefully) also add torchao and optimum-quanto support in the near future. Should those also be skipped on XPU?

Yes, we can skip as of now. And torchao and optimum-quanto is in our priority enabling list, once they are enabled in xpu, we will submit PR to remove the skipping.

faaany commented 2 months ago

If these tests live in a separate file or folder, we could also ignore them using pytest --ignore to save code in codebase.

BenjaminBossan commented 2 months ago

I agree that the organization of tests is a bit messy in PEFT, but let's keep them as is for now, I don't think these few extra lines of code are hurting.