search

huggingface / peft

🤗 PEFT: State-of-the-art Parameter-Efficient Fine-Tuning.
https://huggingface.co/docs/peft
Apache License 2.0
16.46k stars 1.62k forks source link

MNT Remove Python 3.8 since it's end of life #2135

Closed BenjaminBossan closed 3 weeks ago

BenjaminBossan commented 1 month ago

The end of life of Python 3.8 has arrived:

https://devguide.python.org/versions/

Therefore, Python 3.8 is removed from CI. Many tests are already failing as a transformers import raises an error that looks like it's caused by missing Python 3.8 support:

E RuntimeError: Failed to import transformers.models.auto because of the following error (look up to see its traceback): E 'type' object is not subscriptable

(example 1, example 2)

By default, Python 3.11 is now used.

Python 3.12 should be added to the CI matrix now, but that's for a separate PR.

HuggingFaceDocBuilderDev commented 1 month ago

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

BenjaminBossan commented 1 month ago

Update: The transformers issue might be unintended and not caused by intentionally dropping support for Python 3.8, which is only planned for the end of the month (see internal discussion #transformers-tests).

Edit: This should now be fixed on transformers, let's wait what CI says tomorrow. Regardless of that, since Python 3.8 will drop at the end of the month (Oct 2024), let's keep this PR open and merge then.

sayakpaul commented 1 month ago

Will propagate this into diffusers once this PR is merged. Cc: @yiyixuxu