search

huggingface / ratchet

A cross-platform browser ML framework.
https://ratchet.sh
MIT License
631 stars 33 forks source link

ci: fix windows PATH env #241

Closed ocavue closed 3 months ago

ocavue commented 3 months ago

I believe echo "PATH=$LIBTORCH/lib;$PATH" >> $env:GITHUB_ENV breaks the PATH on Windows, and causes milliewalky/setup-7-zip@v1 not working (i.e. cannot find curl). This PR fixes the issue by using the GITHUB_PATH (not GITHUB_ENV) for adding PATH.

Docs: https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/workflow-commands-for-github-actions#adding-a-system-path

github-actions[bot] commented 3 months ago
Code Metrics Report 
  ===============================================================================
 Language            Files        Lines         Code     Comments       Blanks
===============================================================================
 TOML                    1           70           58            2           10
-------------------------------------------------------------------------------
 Rust                   66        14511        12415          201         1895
 |- Markdown            35          343            0          272           71
 (Total)                          14854        12415          473         1966
===============================================================================
 Total                  67        14581        12473          203         1905
===============================================================================
FL33TW00D commented 3 months ago

🦸🏻