Compilation fail due to test error

BananPrzydawka commented 3 months ago

System Info

arch linux, python 3.12.4, i dont know what other info to give here

Information

[X] The official example scripts
[ ] My own modified scripts

Reproduction

installing python-safetensors 0.4.3 (latest package, and up to date with latest safetensors release) from the arch linux aur. package starts compiling but fails and aborts on final check.

full info given during install: ==> Making package: python-safetensors 0.4.3-2 (Fri Jun 28 13:32:22 2024) ==> Retrieving sources... -> Found python-safetensors-0.4.3.tar.gz ==> Validating source files with sha512sums... python-safetensors-0.4.3.tar.gz ... Passed ==> Making package: python-safetensors 0.4.3-2 (Fri Jun 28 13:32:22 2024) ==> Checking runtime dependencies... ==> Checking buildtime dependencies... ==> Retrieving sources... -> Found python-safetensors-0.4.3.tar.gz ==> Validating source files with sha512sums... python-safetensors-0.4.3.tar.gz ... Passed ==> Removing existing $srcdir/ directory... ==> Extracting sources... -> Extracting python-safetensors-0.4.3.tar.gz with bsdtar ==> Starting prepare()... ==> Sources are ready. python-safetensors-0.4.3-2: parsing pkg list... ==> Making package: python-safetensors 0.4.3-2 (Fri Jun 28 13:32:23 2024) ==> Checking runtime dependencies... ==> Checking buildtime dependencies... ==> WARNING: Using existing $srcdir/ tree ==> Removing existing $pkgdir/ directory... ==> Starting build()...

Getting build dependencies for wheel...
Building wheel... Running maturin pep517 build-wheel -i /usr/bin/python --compatibility off 🍹 Building a mixed python/rust project 🔗 Found pyo3 bindings 🐍 Found CPython 3.12 at /usr/bin/python 📡 Using build options features, bindings from pyproject.toml Compiling target-lexicon v0.12.14 Compiling proc-macro2 v1.0.80 Compiling unicode-ident v1.0.12 Compiling once_cell v1.19.0 Compiling autocfg v1.2.0 Compiling libc v0.2.153 Compiling serde v1.0.197 Compiling parking_lot_core v0.9.9 Compiling serde_json v1.0.115 Compiling heck v0.4.1 Compiling portable-atomic v1.6.0 Compiling scopeguard v1.2.0 Compiling smallvec v1.13.2 Compiling cfg-if v1.0.0 Compiling ryu v1.0.17 Compiling itoa v1.0.11 Compiling unindent v0.2.3 Compiling indoc v2.0.5 Compiling lock_api v0.4.11 Compiling quote v1.0.36 Compiling memoffset v0.9.1 Compiling syn v2.0.59 Compiling pyo3-build-config v0.21.1 Compiling memmap2 v0.9.4 Compiling parking_lot v0.12.1 Compiling pyo3-ffi v0.21.1 Compiling pyo3 v0.21.1 Compiling pyo3-macros-backend v0.21.1 Compiling serde_derive v1.0.197 Compiling pyo3-macros v0.21.1 Compiling safetensors v0.4.3 (/home/banan/.cache/paru/clone/python-safetensors/src/safetensors-0.4.3/safetensors) Compiling safetensors-python v0.4.3 (/home/banan/.cache/paru/clone/python-safetensors/src/safetensors-0.4.3/bindings/python) Finished release profile [optimized] target(s) in 21.04s 📦 Built wheel for CPython 3.12 to /home/banan/.cache/paru/clone/python-safetensors/src/safetensors-0.4.3/bindings/python/target/wheels/safetensors-0.4.3-cp312-cp312-linux_x86_64.whl /home/banan/.cache/paru/clone/python-safetensors/src/safetensors-0.4.3/bindings/python/target/wheels/safetensors-0.4.3-cp312-cp312-linux_x86_64.whl Successfully built safetensors-0.4.3-cp312-cp312-linux_x86_64.whl ==> Starting check()... =========================================================================================================== test session starts ============================================================================================================ platform linux -- Python 3.12.4, pytest-8.1.2, pluggy-1.4.0 benchmark: 4.0.0 (defaults: timer=time.perf_counter disable_gc=False min_rounds=5 min_time=0.000005 max_time=1.0 calibration_precision=10 warmup=False warmup_iterations=100000) rootdir: /home/banan/.cache/paru/clone/python-safetensors/src/safetensors-0.4.3/bindings/python configfile: setup.cfg plugins: benchmark-4.0.0, anyio-4.3.0, typeguard-4.2.1 collected 56 items / 1 error

================================================================================================================== ERRORS ================================================================================================================== _ ERROR collecting tests/test_tfcomparison.py tests/test_tf_comparison.py:3: in import h5py /usr/lib/python3.12/site-packages/h5py/init.py:37: in from ._conv import register_converters as _register_converters, \ h5py/_conv.pyx:1: in init h5py._conv ??? h5py/h5r.pyx:1: in init h5py.h5r ??? h5py/h5p.pyx:1: in init h5py.h5p ??? E ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject ========================================================================================================= short test summary info ========================================================================================================== ERROR tests/test_tf_comparison.py - ValueError: numpy.dtype size changed, may indicate binary incompatibility. Expected 96 from C header, got 88 from PyObject !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! ============================================================================================================= 1 error in 2.17s ============================================================================================================= ==> ERROR: A failure occurred in check(). Aborting... error: failed to build 'python-safetensors-0.4.3-2': error: packages failed to build: python-safetensors-0.4.3-2

Expected behavior

expected behaviour is it installs correctly. im not 100% sure this is the right place for this issiue. im sorry for bothering you if it isnt. thanks in advance :D

github-actions[bot] commented 2 months ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

BananPrzydawka commented 2 months ago

Why automatically reject unadressed issiues? To this day i am not able to install the safetensors package

Narsil commented 2 months ago

Because issues that do not receive attention need to be removed from visible list. It's always easy to resurect them, comment on them, like you are doing so we know they are still valid.

You are not explaining how you are trying to install at all python-safetensors is not a package maintained here so we cannot make any changes.

The error seems to suggest there is an issue with the numpy version pre-packages in the thing your referring to. This library does not maintain a dependency on numpy nor is linked against it.

Please report this issue to whereever the package, most likely here: https://aur.archlinux.org/packages/python-safetensors

huggingface / safetensors