Closed Wauplin closed 2 months ago
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.
Hello!
Apologies for the delay! I've merged these changes into main
and resolved the remaining outstanding issues as well. I expect this'll all be included in a release quite soon (this week?). Thanks a bunch for making this PR!
Related to discussion triggered by https://github.com/huggingface/huggingface_hub/issues/2157 (also internal slack).
SetFitModel
class is currently a dataclass which doesn't seem necessary and can have weird side-effect (especially withModelHubMixin
). This PR:@dataclass
fromSetFitModel
SetFitModel
inherit fromModelHubMixin
instead ofPytorchModelHubMixin
. The former is the generic class. The later is a specific class for model inheriting fromnn.Module
which is not the case here. The only benefit ofPytorchModelHubMixin
is to have_from_pretrained
and_save_pretrained
already implemented to load torch weights but in SetFit those methods are inherited anyway (since we don't want to load torch weights)SpanSetFitModel
andPolarityModel
accordinglycc @lewtun @tomaarsen @LysandreJik changes should work correctly but I haven't tested them extensively (especially the
SpanSetFitModel
subclass). Please let me know if you think of any oversight/other things to change.