huggingface / text-generation-inference

Large Language Model Text Generation Inference
http://hf.co/docs/text-generation-inference
Apache License 2.0
8.64k stars 1k forks source link

Some typo error in the picture of flash_attention.md #2057

Closed yejunjin closed 1 month ago

yejunjin commented 2 months ago

System Info

The notation in last Write phase in Flash attention part of the picture, shoule be Write $O_i, l_i, m_i$ instead of $O_i, l_i, v_i$. image

Information

Tasks

Reproduction

No Need

Expected behavior

Fix flash_attention.md

LysandreJik commented 2 months ago

Thanks for mentioning it @yejunjin!

@merveenoyan I believe you contributed this image initially, could you confirm? I'm happy to replace the image if so.

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.