pyo3: update to 0.20 - Githubissues

huggingface / tokenizers

💥 Fast State-of-the-Art Tokenizers optimized for Research and Production

https://huggingface.co/docs/tokenizers

Apache License 2.0

8.69k stars 747 forks source link

Closed mikelui closed 6 months ago

mikelui commented 8 months ago

python: update to pyo3 0.20
small update for change in PyDict::get_item which now returns a PyResult<Option<&PyAny>> instead of Option<&PyAny>
removed some unused imports causing build warnings/errors

HuggingFaceDocBuilderDev commented 8 months ago

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

ArthurZucker commented 6 months ago

Thanks for opening the PR and sorry for missing it

alanhdu commented 6 months ago

@ArthurZucker @mikelui -- would it be possible to re-open the PR and merge it in? It looks like it got closed as stale but was not actually merged (at least https://github.com/huggingface/tokenizers/blob/main/bindings/python/Cargo.toml#L17 still points to 0.19)

mikelui commented 6 months ago

I planned on updating this before end of week

Narsil commented 6 months ago

@mikelui what is missing here ?

mikelui commented 6 months ago

@mikelui what is missing here ?

nothing, just wanted to check if there were any tangible changes that would affect merge