huggingface / transformers

🤗 Transformers: State-of-the-art Machine Learning for Pytorch, TensorFlow, and JAX.
https://huggingface.co/transformers
Apache License 2.0
128.7k stars 25.53k forks source link

Add EDSR and MDSR #19631

Open IMvision12 opened 1 year ago

IMvision12 commented 1 year ago

Model description

EDSR (Enhanced Deep Residual Networks for Single Image Super-Resolution) is for image super resolution, here's the paper.

Open source status

Provide useful links for the implementation

Official Implementation https://github.com/sanghyun-son/EDSR-PyTorch and https://github.com/LimBee/NTIRE2017

Your contribution

I'd like to work on incorporating this architecture into the HuggingFace. Please let me know if you think it's worth adding to huggingface.

@NielsRogge can you review this issue so that I can get started

IMvision12 commented 1 year ago

@venkat-natchi

venkat-natchi commented 1 year ago

I'm going through the paper and the existing implementation. I will open the PR in few days.

IMvision12 commented 1 year ago

I'm going through the paper and the existing implementation. I will open the PR in few days.

That's great, I have already gone through the paper and the architecture and started the implementation!

venkat-natchi commented 1 year ago

Sorry, I was away due to festival season here. I am done with the paper. Shall I start transforming this one into the HuggingFace model standards?

IMvision12 commented 1 year ago

Go ahead and let me know if you need any help; I will be adding the MDSR model to the hub, and I believe the code should be similar to this Swin2sr PR also we can use it for reference.

venkat-natchi commented 1 year ago

Sure, thanks

venkat-natchi commented 1 year ago

Can we add both EDSR and MDSR in this PR?

IMvision12 commented 1 year ago

No, I guess a separate PR is required.

asrimanth commented 1 year ago

Hello, can I work on this issue? Although I'm new to open-source contributions, I've worked on super-resolution models in the past and I was wondering why HuggingFace did not have these. I am familiar with PyTorch.

venkat-natchi commented 1 year ago

Thanks @asrimanth for the interest. I have an active PR going on for this issue.

19952

Kindly leave your comments there if you could.