search

huggingface / transformers

🤗 Transformers: State-of-the-art Machine Learning for Pytorch, TensorFlow, and JAX.
https://huggingface.co/transformers
Apache License 2.0
131.93k stars 26.27k forks source link

[BUG] ModelCard do not write true optimizer #32560

Open relic-yuexi opened 1 month ago

relic-yuexi commented 1 month ago

This code seems to be outdated and does not consider the optim parameter. I might submit a PR to fix it.

https://github.com/huggingface/transformers/blob/e4522fe399641add9b1f3207923752a35ea7fdbb/src/transformers/modelcard.py#L876-L882

qubvel commented 1 month ago

Hi @relic-yuexi, thanks for reporting the issue!

We would appreciate the fix!

aroun-coumar commented 2 weeks ago

Hi @relic-yuexi, may i do the fix Thank you