Open as-suvorov opened 1 week ago
cc @gante I expect that was probably a regression - I have capacity to take this one, but if you think you can fix it quickly, feel free to grab it!
@Rocketknight1 please go ahead with the fix š
@Rocketknight1 , @gante thank you for analysis!
On investigation, this isn't really a bug. The whisper models set return_timestamps=False
in their generation_config.json
, which means it will be used as the default value. The only change is that this value is now being correctly loaded by the pipelines.
@gante I think the new behaviour is probably more correct, and users should just set return_timestamps=True
to override the JSON config when they need to?
System Info
transformers
version: 4.45.2Who can help?
@gante @Rocketknight1
Information
Tasks
examples
folder (such as GLUE/SQuAD, ...)Reproduction
reproducer.py
Steps to reproduce:
pip install datasets transformers=4.44.2
python reproducer.py
Actual behavior - pipeline completes successfullypip install transformers=4.45.0
python reproducer.py
Actual behavior - pipeline completes fails with error:Expected behavior
There is a change in asr pipeline behavior between transformers versions
4.44.2
and4.45.0
. Exact PR: Pipeline: no side-effects on model.config and model.generation_config.Transformers version
4.44.2
long-form processing doesn't requirereturn_timestamps=True
, completes successfully. Version4.45.0
requiresreturn_timestamps=True
, fails otherwise.Is it intended change in behavior?