huggingface / trl

Train transformer language models with reinforcement learning.
http://hf.co/docs/trl
Apache License 2.0
10.18k stars 1.29k forks source link

Fix dev install #2369

Closed lewtun closed 6 days ago

lewtun commented 1 week ago

What does this PR do?

Fixes an issue where repeated use of make dev fails due to the symbolic link creation. The fix is to check/unlink an existing symlink and recreate it if needed.

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

lewtun commented 6 days ago

Yes I agree this symlink business was not a great choice for the chat CLI. Let's revisit later