huggingface / trl

Train transformer language models with reinforcement learning.

http://hf.co/docs/trl

Apache License 2.0

10.18k stars 1.29k forks source link

⏰ Add `start_time` to `_maybe_log_save_evaluate` #2373

Closed qgallouedec closed 5 days ago

qgallouedec commented 6 days ago

What does this PR do?

Follows https://github.com/huggingface/transformers/pull/34507

cc @SunMarc @muellerzr for visibility

Before submitting

[ ] This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
[ ] Did you read the contributor guideline, Pull Request section?
[ ] Was this discussed/approved via a GitHub issue? Please add a link to it if that's the case.
[ ] Did you make sure to update the documentation with your changes? Here are the documentation guidelines.
[ ] Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who may be interested in your PR.

HuggingFaceDocBuilderDev commented 6 days ago

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.