search

hughbris / grav-theme-solarize

Grav port of Solarize theme by Templated
MIT License
5 stars 5 forks source link

Not loading correctly in FF #7

Open godfatherjohn opened 5 years ago

godfatherjohn commented 5 years ago

Here's the log:

Unrecognised at-rule or error parsing at-rule '@-ms-viewport'. solarize:1:14
Error in parsing value for 'perspective'.  Declaration dropped. solarize
Error in parsing value for 'transform'.  Declaration dropped. solarize:3:25
hughbris commented 5 years ago

Thank you for the report. To look at this, could I please have some more information?

godfatherjohn commented 5 years ago
hughbris commented 5 years ago

OK thanks. I should have asked in the previous message: could you check if you get the error in the source template demo from Templated?

If the bug is in the original template and is not simply fixed, I probably won't fix this myself. I'll be unlikely to use Templated's templates again too! :(

I'm investigating the console messages now and will post my findings shortly.

hughbris commented 5 years ago

In Firefox console log, on the right do the errors have hyperlinks to those errors? It's difficult for me to pinpoint the parts of the theme where these errors originate.

I have searched the theme code and cannot find 'ms-viewport', 'perspective', or 'transform' (on its own). I think they might be loaded by an external library like Font Awesome.

I did find '@-ms-viewport' and 'transform' searching the generated source in Inspector. I don't think the 'transform' match is triggering the error though:

<div id="skel-layers-wrapper" style="position: relative; left: 0px; right: 0px; top: 0px; backface-visibility: hidden; transition: -webkit-transform 0.25s ease-in-out 0s;">

'@ms-viewport' is directly beneath the <head> opening tag:

<style type="text/css">@-ms-viewport{width: device-width}</style>

Because this is not in the theme source, I have to assume it is being generated by a script that is loaded by the theme (like skel.js). I'm afraid my skills with Inspector don't extend to investigating the source of the error further. I would love to learn though!

One more thing: I think only the first console message is a fatal error. The latter two just seem like warnings.

So if you can give me any further info I am happy to keep looking, but this is looking like a 3rd party problem. I will, however, fix #8 soon just in case this is somehow causing your FF problem.

hughbris commented 5 years ago

Issue #8 is now addressed and uploaded to the demo site, so worth testing there again in your FF :)

kai47110815 commented 5 years ago

Testing might be worth using one of these services as well:

godfatherjohn commented 5 years ago

Just FYI - I have tried to display the Solarize Grav demo page in FF. The issue seems to persist, still. I have attached a screenshot. ..In Chrome/Brave, it is working fine.
Solarize display issues

hughbris commented 5 years ago

Thanks. Spending time testing browser quirks sits well outside of tasks I enjoy as a web developer.

So with this theme I've just tried to recreate Templated's theme accurately in Grav. Since I have no active deployments of the theme except my demo, I'm not motivated to tweak it beyond faithfully reproducing. Ideally Templated would allow issues to be raised on their published themes, but they don't :/ And as I've mentioned in another issue, I think the way they use their framework and JS to handle CSS loading is very risky. I originally built the theme for a client I never received money from, so it's a gift for anyone else. I do appreciate your report though!

Still keen to know what your version of FF does on Templated's original.

Will keep this open because I will be much more concerned if it continues to fail on future versions of FF. If we are lucky it's mainly limited to your version.

Cheers :)

godfatherjohn commented 5 years ago

I have just checked your theme on Templated.co, it's being displayed correctly and in full. Apologies for the delay. Also, apologies for not investigating this myself but, as you, I don't have the time for this at present.

hughbris commented 5 years ago

Thanks for the update and testing.

I guess that test result puts the fault back in my court. Really hope it's not all subsequent versions of FF. I'll diff my theme's output and the source theme to try to get to the bottom of this when I have some time.