search

hugheylab / phers

https://phers.hugheylab.org
0 stars 0 forks source link

simplify function to map diseases to phecodes #15

Closed jakejh closed 2 years ago

jakejh commented 2 years ago

Is there any real disadvantage to removing diseaseIds as an argument to this function and just letting the user subset the data.table afterwards? I argue that subsetting is not this function's core responsibility.

https://github.com/hugheylab/phers/blob/c2478dc7baee656417e24604a3a5b50d7800eecd/R/map.R#L88

arefnel commented 2 years ago

40ba6de11ac9c92f50af939817c054f81a47a710