search

hugheylab / phers

https://phers.hugheylab.org
0 stars 0 forks source link

simplify code in diseasePhecodeMap #16

Closed jakejh closed 2 years ago

jakejh commented 2 years ago

Instead of silently excluding empy phecode != '', I think the function should require that hpoPhecodeMap not contain any empty strings or NAs (use assertCharacter). Let's make sure the default map in the package meets those criteria.

https://github.com/hugheylab/phers/blob/40ba6de11ac9c92f50af939817c054f81a47a710/R/map.R#L149-L150

arefnel commented 2 years ago

b3c042b14999384c3e65e4920734d1609dfb0d13