search

hugheylab / phers

https://phers.hugheylab.org
0 stars 0 forks source link

Age aware phers #78

Closed arefnel closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Base: 84.22% // Head: 97.13% // Increases project coverage by +12.90% :tada:

Coverage data is based on head (7017229) compared to base (c828693). Patch coverage: 93.43% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #78 +/- ## =========================================== + Coverage 84.22% 97.13% +12.90% =========================================== Files 6 6 Lines 317 384 +67 =========================================== + Hits 267 373 +106 + Misses 50 11 -39 ``` | [Impacted Files](https://codecov.io/gh/hugheylab/phers/pull/78?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hugheylab) | Coverage Δ | | |---|---|---| | [R/genetic\_association.R](https://codecov.io/gh/hugheylab/phers/pull/78/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hugheylab#diff-Ui9nZW5ldGljX2Fzc29jaWF0aW9uLlI=) | `100.00% <ø> (ø)` | | | [R/genetic\_diagnosis.R](https://codecov.io/gh/hugheylab/phers/pull/78/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hugheylab#diff-Ui9nZW5ldGljX2RpYWdub3Npcy5S) | `100.00% <ø> (ø)` | | | [R/phers.R](https://codecov.io/gh/hugheylab/phers/pull/78/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hugheylab#diff-Ui9waGVycy5S) | `87.83% <66.66%> (-10.60%)` | :arrow_down: | | [R/utils.R](https://codecov.io/gh/hugheylab/phers/pull/78/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hugheylab#diff-Ui91dGlscy5S) | `98.50% <97.43%> (-0.53%)` | :arrow_down: | | [R/weights.R](https://codecov.io/gh/hugheylab/phers/pull/78/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hugheylab#diff-Ui93ZWlnaHRzLlI=) | `100.00% <100.00%> (ø)` | | | [R/examples.R](https://codecov.io/gh/hugheylab/phers/pull/78/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hugheylab#diff-Ui9leGFtcGxlcy5S) | | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hugheylab). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=hugheylab)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jakejh commented 2 years ago

@arefnel This is pretty good, here are some thoughts:

  1. What happens if someone enters method = 'loglinear'?
  2. Please add appropriate tests.
  3. Add space after if.
  4. I don't think we need to include the dx_status column in the output of getWeights(). I might also suggest we only return rows with non-zero weights, just to keep the output smaller.
jakejh commented 2 years ago

Excellent work, @arefnel . I just polished a few things. Go ahead and merge!