Open hughjazzman opened 3 years ago
I suggest this deserve Medium severity than a High one. Most of them only have the return for increasing testability only
Team chose [severity.Medium
]
Originally [severity.High
]
Reason for disagreement: The CommandChecker
class present in the diagram contradicts UML notation - it still appears out of the blue. Maybe consider having a method call from WritingList
or CommandExecutor
to CommandChecker
? It is still not clear which Class actually calls the method, and which executes it. This flaw causes the diagram to be unusable.
Perhaps consider returning control? It looks like multiple diagrams have this issue.
There is also a
CommandChecker
class which pops up when no control was passed to it.