search

hughpearse / DCU-CA683-workspace

0 stars 0 forks source link

QA Testing #14

Closed hughpearse closed 5 years ago

hughpearse commented 5 years ago

Given a release candidate test the implementation:

  1. Create a test plan
  2. execute the tests
  3. Record the results.

Test plan should include missing data and performance evaluation. The architecture document says to "Create a Validation Dataset, Split data into 80%:20% ratio. 80% to train model and 20% to validate dataset".

Review the architecture document (#12) and business requirements (#11) to verify that the requirements are met.

The iris dataset is available here https://github.com/hughpearse/DCU-CA683-workspace/blob/master/iris.csv

MitalKasundra commented 5 years ago

@hughpearse @DeeCorr @DeeCorr

Getting an error when passing test and training csv to summary.main() https://drive.google.com/open?id=1XXTQ9rKpuA6OWVf1EUN-DBDcSS0l7SRb

It's trying to calculate the mean of 'class' column. I think class needs to be coverted to a categorical variable. (like factor in R)

image

MitalKasundra commented 5 years ago

evaluator was giving following error. image

I fixed it by changing the image

MitalKasundra commented 5 years ago

Happy with the evaluator file outcome. If someone fixes error in the summary file, I am happy to move this from QA.

MitalKasundra commented 5 years ago

I have fixed the summary code.

Happy to sign off QA.

hughpearse commented 5 years ago

@MitalKasundra have you delivered the suggested fixes?

MitalKasundra commented 5 years ago

QA Script https://drive.google.com/open?id=1XXTQ9rKpuA6OWVf1EUN-DBDcSS0l7SRb