search

hughperman / pure-lang

Automatically exported from code.google.com/p/pure-lang
0 stars 0 forks source link

distcheck supported on systems where GNU make is not "make" #31

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
What steps will reproduce the problem?
1. using an OS where GNU make is not called "make"
2. ./configure --whatever && $gmake distcheck
3. observe the OS's native make spit out syntax errors

Please provide any additional information below.

See the attached patch.

Original issue reported on code.google.com by neuhau...@sigpipe.cz on 28 Apr 2010 at 11:21

GoogleCodeExporter commented 8 years ago 
also, another patch to enable distcheck success where plain "./configure" 
without
further options would fail.

Original comment by neuhau...@sigpipe.cz on 28 Apr 2010 at 11:23

GoogleCodeExporter commented 8 years ago 
erm, sorry, wrong patches.  see the new attachments.

Original comment by neuhau...@sigpipe.cz on 28 Apr 2010 at 11:37

Attachments:

GoogleCodeExporter commented 8 years ago 
I'm wondering about the name of the variable for setting the configure flags for
'make distcheck' in p2-e9b7e6df7cf6.patch. Is that variable supposed to be set 
by the
configure script or by the user?

Original comment by aggraef@gmail.com on 17 May 2010 at 5:04

GoogleCodeExporter commented 8 years ago 
by the user.  my thinking was: the distcheck target is a maintainer/contributor 
thing, such 
a person might want to a) default to the user-level default (./configure with 
no options) and 
still allow trying out different combinations.  plus it was the smallest change 
that got me 
through distcheck.

.... don't you hate how code.google.com won't let you preview the patch?

Original comment by neuhau...@sigpipe.cz on 17 May 2010 at 5:42

GoogleCodeExporter commented 8 years ago 
Applied in r3403. I named the variable DISTCHECK_CONFIGURE_FLAGS, though, since 
this
is what automake uses for the same purpose, so it can be considered a kind of 
standard.

About the missing patch preview: Yeah, it's somewhat annoying that you have to
download the patch in order to view it. Maybe you'd like to submit that to GC's 
issue
tracker?

Original comment by aggraef@gmail.com on 18 May 2010 at 5:25

GoogleCodeExporter commented 8 years ago 
cool, i didn't know about DISTCHECK_CONFIGURE_FLAGS.

"view attachment" has already been requested:
http://code.google.com/p/support/issues/detail?id=2976 you may want to star the 
issue
(as i did)

Original comment by neuhau...@sigpipe.cz on 18 May 2010 at 8:57