search

hughsie / appstream-glib

This library provides objects and helper methods to help reading and writing AppStream metadata.
GNU Lesser General Public License v2.1
65 stars 103 forks source link

Don't emit legacy component type values #415

Closed ximion closed 3 years ago

ximion commented 3 years ago

Emitting the old names was likely kept to not create any breakage and provide full backwards compatibility between different versions. However, asglib has supported the new names for years now and emitting the older ones actually causes problems now, in the case of webapp: https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/899 This change also makes asglib emit desktop-application instead of desktop, which likely doesn't fix any real-world issues, as we'll keep the desktop alias forever, but it's nice to emit the full name for consistency.

hughsie commented 2 years ago

I reverted this, it broke the self tests in lots of places.

ximion commented 2 years ago

I would argue that these tests should probably be fixed ;-) At least "webapp" was never standardized and libappstream will not recognize it ("desktop" is a different case, that one will probably be supported until the universe dies, way beyond AppStream 1.0 at least).