hughsie / appstream-glib

This library provides objects and helper methods to help reading and writing AppStream metadata.
GNU Lesser General Public License v2.1
65 stars 103 forks source link

Unknown tag 'a' #425

Open Doomsdayrs opened 2 years ago

Doomsdayrs commented 2 years ago

Trying to add any form of link into an appdata.xml via causes the parse to fail.

Examples:

<a> in <p>

Error loading AppData file: failed to parse /app/share/appdata/com.lunarclient.Launcher.appdata.xml: Error on line 288 char 173: <p> already set 'You further acknowledge and agree that by using Minecraft or setting up a Minecraft account, you may be subject to an agreement(s) with the Microsoft Corporation and/or Mojang AB. For your reference, Mojang’s terms and conditions are available' and tried to replace with ' and the Microsoft services agreement is available '

standalone

Error loading AppData file: failed to parse /app/share/appdata/com.lunarclient.Launcher.appdata.xml: Unknown tag 'a'
ximion commented 2 years ago

Links are not allowed there, so this is expected behavior. You can set links via an URL tag if it fits in any of the existing catgories: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-url To add any kind of agreement that a user has to accept, the <agreement/> tag can be used: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-agreement

Doomsdayrs commented 2 years ago

.. Why would links not be allowed in licenses etc?