hughsie / colord

Making color management just work
GNU General Public License v2.0
75 stars 51 forks source link

tests: Make the build reproductible #107

Closed bigon closed 4 years ago

bigon commented 4 years ago

Fixes: #106

bigon commented 4 years ago

@hughsie I was thinking about something like that

hughsie commented 4 years ago

So that indeed makes it reproducible, but also disables the self tests..

bigon commented 4 years ago

@hughsie OK my new patch is better, and the tests are passing

hughsie commented 4 years ago

@superm1 -- I know this is nothing to do with you, but could you review as I guess we'll have to do the same workaround for fwupd and our other projects.

superm1 commented 4 years ago

@bigon would you mind doing the same kind of PR to fwupd too? I know Debian has had a reproducible builds failure there for a while and it's most likely this exact same problem.

bigon commented 4 years ago

@superm1 I can have a look later

hughsie commented 4 years ago

I can have a look later

I think libxmlb is probably affected like this too.

bigon commented 4 years ago

@hughsie Weird, both fwupd and libxmlb are fine

But indeed looking at the code, they use the same method 🤔

superm1 commented 4 years ago

@hughsie Weird, both fwupd and libxmlb are fine

But indeed looking at the code, they use the same method 🤔

That's super bizarre. I definitely saw failures in buster I remember. I think submit the changes anyway. They do make sense for reproducible builds to keep working.