search

hughsie / colord

Making color management just work
GNU General Public License v2.0
75 stars 51 forks source link

colormgr create-profile using scope disk creates profile despite error #154

Open 01-1 opened 1 year ago

01-1 commented 1 year ago

This is just a minor issue, but when I run colormgr create-profile test0 disk, (test0 is a placeholder) it seems to create a profile even though it results in an error message: persistent profiles are no yet supported, because if you then run colormgr create-profile test0 normal or temp, it says profile id 'test0' already exists. It is possible to delete this with delete-profile though.

Also there's a typo here: "persistent profiles are no yet supported" should be "persistent profiles are not yet supported". https://github.com/hughsie/colord/blob/d7352455075f6a6eb32e7d256dadb436cbd15ae8/src/cd-main.c#L229

btw there's like no documentation for this (what the options are) :skull: actually i'm not too sure what this command even does, I don't see the newly-created profile in colormgr get-profiles?

01-1 commented 1 year ago

It also seems that this happens for import-profile when it times out (see #140): it says The profile <path to profile> already exists.

<path to profile> is of the form <home directory>/.local/share/<filename>.icm.

01-1 commented 1 year ago

Actually the only way to "fix" this (to delete the profile) that I found is, run colormgr find-profile-by-filename <path to profile>. That outputs Failed to connect to missing profile /org/freedesktop/ColorManager/profiles/icc_<a bunch of hex>_i_1000. Then input this path into delete-profile.