search

hughsie / colord

Making color management just work
GNU General Public License v2.0
75 stars 51 forks source link

meson.build: set FILE_OFFSET_BITS explicitly #159

Closed thesamesam closed 11 months ago

thesamesam commented 11 months ago

This is needed if building introspection because: a) Meson's own setting of FILE_OFFSET_BITS (which it does by default) doesn't affect the introspection tooling;

b) glibc's headers seem to react poorly to just _TIME_BITS being set, even though in this cas, the failure was for a 64-bit ABI anyway.

This is effectively a noop given meson always sets -D_FILE_OFFSET_BITS=64, it just didn't get propagated to the right bit, and we didn't notice until the change in ce9732a87bc2a0ddca841b49b9b9e24351ea78c8.

Fixes: ce9732a87bc2a0ddca841b49b9b9e24351ea78c8

thesamesam commented 11 months ago

I'm going to speak to the meson people about a) at least because it seems unusual.