Stop forcing C99 - Githubissues

hughsie / colord

Making color management just work

GNU General Public License v2.0

75 stars 51 forks source link

Stop forcing C99 #81

Open jbicha opened 6 years ago

jbicha commented 6 years ago

I propose that we revert https://github.com/hughsie/colord/commit/b5436b49d7d

That commit forces the C99 standard to be used. Otherwise, it would build with C11 on newer distros. (There are some comments on the commit.)

hughsie commented 6 years ago

Why do we want to build with C11? Are there any C11 features we use? Is there any performance increase? The original commit fixed a bug on old GCC versions.

jbicha commented 6 years ago

Do you still support old GCC?

hughsie commented 6 years ago

I guess I support the GCC in rhel 7 -- although a lot of people use older gccs than that. I still don't really understand why you want to use C11 mode...

jbicha commented 6 years ago

Ok, feel free to close if this is intentional. Sorry to bother you.